Skip to content

Disable more bundles tests that fail in Windows CI #440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 28, 2021

Conversation

dconeybe
Copy link
Contributor

The following two tests are being disabled:

  • BundleTest.LoadBundleWithDocumentsAlreadyPulledFromBackend
  • BundleTest.LoadedDocumentsShouldNotBeGarbageCollectedRightAway

@google-cla google-cla bot added the cla: yes label May 27, 2021
@dconeybe dconeybe added the tests-requested: quick Trigger a quick set of integration tests. label May 27, 2021
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: quick Trigger a quick set of integration tests. labels May 27, 2021
@github-actions
Copy link

github-actions bot commented May 27, 2021

✅  Integration test succeeded!

Requested by @dconeybe on commit 2f10d5b
Last updated: Thu May 27 13:32:04 PDT 2021
View integration test results

@github-actions github-actions bot added the tests: succeeded This PR's integration tests succeeded. label May 27, 2021
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label May 27, 2021
@chkuang-g chkuang-g enabled auto-merge May 27, 2021 21:46
@chkuang-g chkuang-g disabled auto-merge May 27, 2021 21:47
@dconeybe dconeybe merged commit 5c7390c into main May 28, 2021
@dconeybe dconeybe deleted the dconeybe/DisableBrokenBundlesTestsOnWindows branch May 28, 2021 05:23
@firebase firebase locked and limited conversation to collaborators Jun 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api: firestore cla: yes tests: succeeded This PR's integration tests succeeded.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants